OptionManagement.validateOption throws NoSuchEntityException for "0" option label

[rzinnatullin]

Preconditions

1. Magento 2.1.11 (and 2.2.2 I suppose)

Steps to reproduce

1. Create a product attribute of 'dropdown' type via admin page with one option (Admin value: 0, Default Store View value: 0)
2. Programmatically delete the option using OptionManagement.delete method

    /**
     * @var \Magento\Eav\Api\AttributeOptionManagementInterface
     */
    private $optionManagement;
...
    $this->optionManagement->delete(\Magento\Catalog\Model\Product::ENTITY, $attributeCode, $optionId);

Expected result

1. The option should be delete w/o any errors

Actual result

1. NoSuchEntityException with message Attribute <somecode> does not contain option with Id <someId> is thrown

Root cause

There is validateOption method in OptionManagement.php that checks if option exists:

getOptionText returns "0" string as it is supposed to:

So the root cause is in validateOption method (see the first screenshot). In line 135 it does logical NOT operator, so "0" is casted to FALSE, thus the condition is TRUE. To fix the issue the comparison should be exact: === FALSE.

[orlangur]

Hi @rzinnatullin, thanks for comprehensive investigation!

Are you interested in preparing a pull request maybe? They are processed pretty fast nowadays, it would speed up fix availability for everyone and also it is easier to discuss concrete code snippet.

[magento-engcom-team]

@rzinnatullin, thank you for your report.
We've acknowledged the issue and added to our backlog.

[sidolov]

Hi @rzinnatullin. Thank you for your report.
The issue has been fixed in #18720 by @pmclain in 2.3-develop branch
Related commit(s):

• ed6a2fba850caa5e2402663fee133d4f56545200

The fix will be available with the upcoming 2.3.1 release.