Apostrophe in attribute option value in admin is not handled properly

[erfanimani]

Preconditions

1. Magento 2.1 and 2.2
2. Chrome 62

Steps to reproduce

1. As an admin, go to Stores -> Attributes -> Products -> Manufacturer
2. Add a new attribute option called "Nature's Way Supplements"
3. Hit "Save and continue"
4. Hit "Save and continue" again

Expected result

1. In the admin, the attribute option value text input should say "Nature's Way Supplements"
2. If you check the value in the database, it should be "Nature's Way Supplements"

Actual result

1. The text input says: Nature's Way Supplements
2. The database entry says: Nature's Way Supplements

After the first time of saving, the database looks alright, but the input value is wrong. This causes another save not to be idempotent. The bad escape causes side-effects, and this causes all sorts of issues — double escaping, imports not running because now the attribute options don't match up, and so on.

If that's not convincing, storing HTML escaped values int the database is clearly wrong — it should only be escaped if outputted to a web page, the database entry should be as close to the original user input as possible.

Couple other people are complaining about this on Stackexchange, i.e. https://magento.stackexchange.com/questions/198673/magento-2-cant-store-apostrophe-in-manufacturer-options

[erfanimani]

I've added a pull request here: #12133

[magento-engcom-team]

@erfanimani, thank you for your report.
We've created internal ticket(s) MAGETWO-83519 to track progress on the issue.

[okorshenko]

The issue has been fixed and delivered to 2.2-develop branch. Will be available with upcoming patch release