Attribute repository resets sourceModel for new attributes

[adi3009]

When creating a new product attribute through code, product attribute repository save method resets source model to null or something else. Therefore a new attribute is created with an empty option (in case of select or multiselect input type). This happens only for new attributes not when updating exiting attributes.

Expected Result

It is expected that when some data is set on a model, repository should not change or reset it.

Preconditions

Magento Version 2.1.7 CE and EE

Product Attribute Repository

Example Code

Steps to reproduce

• Copy Example/Catalog module into app/code directory.

• Install module

  ./bin/magento module:enable "Example_Catalog"
  ./bin/magento setup:upgrade
  ./bin/magento setup:di:compile
  

• Run command to create an example product attribute

  ./bin/magento example:catalog:create_attribute
  

Actual Result

• In magento admin panel you should see attribute example_attribute_code of input type select having just an empty option.

• Run the command again and you should see the attribute has options from source model.

[orlangur]

$attribute->setSourceModel(
                $this->productHelper->getAttributeSourceModelByInputType($attribute->getFrontendInput())
            );

looks perfectly valid to me as you cannot have different source models for the same frontend_input. Just use another frontend_input and map source model properly.

[adi3009]

@orlangur I've updated the example code. I think the repository should only set source model if not set already.

[orlangur]

Again:

• is Magento using different source models for the same frontend input internally?
• what is the problem in mapping your source model with frontend input properly?

[adi3009]

Yes

• Magento uses different source models for several product attributes, e.g. product status (frontend_input is select) etc.
• The problem is in save method of repository where it sets a source model without checking if a source model already set on attribute model data, it does this only for new attributes not when saving existing attribute.

[orlangur]

Ok, thanks for the detailed explanation, it looks like \Magento\Catalog\Helper\Product::getAttributeInputTypes is just a partial implementation currently.

So, you just need a regular new select/multiselect but with custom source model.

Not sure it should be treated as bug report or a feature request, so, leaving without such label for now.