Product image roles randomly disappear

[boxyman]

After upgrading from Magento 2.1.7 to 2.1.8 we had problems with product image roles. We have experienced that some products that previously had product image role set to base, small, thumbnail didn't have it anymore. It seems that the image roles get's removed from random products over time. This weekend at we have at least identified 10 products that got images roles removed during the weekend.

Preconditions

1. Magento 2.1.8
2. PHP 7
3. MySQL 5.7
4. Ubuntu 16.04
5. Nginx
6. Redis
7. Varnish
8. SSL (HTTPS)

Steps to reproduce

1. Go to "Products" > "Catalog"
2. Choose a product
3. Go to "Images And Videos"
4. Click an image
5. Set "Role" to base, small, thumbnail

Expected result

1. Product image roles should be set to base, small, thumbnail unless the user changes it.

Actual result

1. Product image roles disappear randomly from some products from time to time.

Short way to reproduce:

Preconditions

Create product with image and set role image: base, small, thumbnail

Steps to reproduce

Save Product in backend controller like this:

$store = $this->storeManager->getStore(0);
$this->storeManager->setCurrentStore($store);
$product = $this->productRepository->getById($data['product_id'], true, $store->getId());
$this->productRepository->save($product);

Expected result

Product image roles should be set to base, small, thumbnail unless the user changes it.

Actual result

Product image does not have any roles

[kervin]

This is a big issue for us. Any news when this will be fixed?

[RomaKis]

@boxyman, thank you for your report.
We were not able to reproduce this issue by following the steps you provided.
Please provide more details regarding your environment, or try to reproduce this
issue on a clean installation.

[kervin]

I think it's only when you save a product programmatically.

The problem that I found it when you set the current store to admin..

    // Set to Admin Store
    // When this is set, product images disappear
    // $store = $this->storeManager->getStore(0);
    // $this->storeManager->setCurrentStore($store->getCode());

[magento-engcom-team]

@kervin Unfortunately, we could not reproduce the issue as you described it. Please add more details to your description of the steps you followed when identifying this issue. Screenshots or logs would be helpful, too.

[kervin]

Just do the following on 2.1.8. If I do not set current store, it saves products to the default store view.. when I set the store, it breaks the images.

// This line is breaking images

$this->storeManager->setCurrentStore($store);

$product = $this->productRepository->getById($data['product_id'], true, $store->getId());

$this->productRepository->save($product);

[kervin]

I found a workaround, unset media_gallery, if you are not changing images.

$product->unsetData('media_gallery');
$this->productRepository->save($product);