🔃 [EngCom] Public Pull Requests - 2.3-develop

Accepted Public Pull Requests:
 - #14333: Registry deprecation (by @vkublytskyi)
 - #14304: Resolves PHPdoc issue in ticket #13992 (by @cream-julian)
 - #14266: Remove VarienForm as it no longer appears to be included or used. (by @jonathanKingston)


Fixed GitHub Issues:
 - #13992: Incorrect phpdoc should be Shipment\Item not Invoice\Item (reported by @ThisIsRuddy) has been fixed in #14304 by @cream-julian in 2.3-develop branch
   Related commits:
     1. 79c1b4f

Author: magento-engcom-team

app/code/Magento/Sales/Model/Order/Shipment/Item.php

@@ -144,7 +144,7 @@ public function getOrderItem()
      * Declare qty
      *
      * @param float $qty
-     * @return \Magento\Sales\Model\Order\Invoice\Item
+     * @return \Magento\Sales\Model\Order\Shipment\Item
      * @throws \Magento\Framework\Exception\LocalizedException
      */
     public function setQty($qty)

dev/tests/static/testsuite/Magento/Test/Js/_files/blacklist/magento.txt

@@ -25,5 +25,4 @@ lib/web/mage/adminhtml/tools.js
 lib/web/mage/adminhtml/varienLoader.js
 lib/web/magnifier/magnifier.js
 lib/web/magnifier/magnify.js
-lib/web/varien/form.js
 lib/web/varien/js.js

lib/internal/Magento/Framework/Registry.php

@@ -8,7 +8,11 @@
 /**
  * Registry model. Used to manage values in registry
  *
+ * Registry usage as a shared service introduces temporal, hard to detect coupling into system.
+ * It's usage should be avoid. Use service classes or data providers instead.
+ *
  * @api
+ * @deprecated
  */
 class Registry
 {
@@ -24,6 +28,8 @@ class Registry
      *
      * @param string $key
      * @return mixed
+     *
+     * @deprecated
      */
     public function registry($key)
     {
@@ -41,6 +47,8 @@ public function registry($key)
      * @param bool $graceful
      * @return void
      * @throws \RuntimeException
+     *
+     * @deprecated
      */
     public function register($key, $value, $graceful = false)
     {
@@ -58,6 +66,8 @@ public function register($key, $value, $graceful = false)
      *
      * @param string $key
      * @return void
+     *
+     * @deprecated
      */
     public function unregister($key)
     {