🔃 [EngCom] Public Pull Requests - 2.3-develop

Accepted Public Pull Requests:
 - #14661: [Forwardport] Replace the existing headers with the no cache headers (by @rostyslav-hymon)
 - #14318: Move polyfill JavaScript code to be included as a remote script from � (by @jonathanKingston)
 - #14636: [Forwardport] #14465 Fix empty changelog tables after MySQL restart. (by @ihor-sviziev)
 - #14637: #13685: Upgrading compatibility jQuery with 3.3.1 (by @kirmorozov)
 - #14634: 788: Integration test rework. Introduced new extension point for New Shipment Controller to retrieve Shipment Data (by @nmalevanec)
 - #14356: Use `LEFT JOIN` When Checking for `null` Attributes (by @maxbucknell)


Fixed GitHub Issues:
 - #14049: Retrieve session information from another customer under /customer/section/load/sections=&update_section_id=true (reported by @intercase) has been fixed in #14661 by @rostyslav-hymon in 2.3-develop branch
   Related commits:
     1. 9359b43

 - #14465: [Indexes] Product 'version_id' lost last 'auro_increment' value after MySQL restart. (reported by @swnsma) has been fixed in #14636 by @ihor-sviziev in 2.3-develop branch
   Related commits:
     1. 4d29608

 - #13685: Incompatibilies with jQuery 3 (reported by @kirmorozov) has been fixed in #14637 by @kirmorozov in 2.3-develop branch
   Related commits:
     1. ae229f9
     2. b25d28f
     3. ae43898

 - #788: Backend depends on Javascript for saving settings (reported by @nyov) has been fixed in #14634 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. a1db922
     2. 25ee332
     3. 9cda5f0

 - #14312: GraphQL `ProductFilterInput` Requires Field to be a String (reported by @maxbucknell) has been fixed in #14356 by @maxbucknell in 2.3-develop branch
   Related commits:
     1. 7a3ea4e
     2. 4589cb0

 - #14355: Impossible to Filter Collection by `null` Attribute Value (reported by @maxbucknell) has been fixed in #14356 by @maxbucknell in 2.3-develop branch
   Related commits:
     1. 7a3ea4e
     2. 4589cb0

Author: magento-engcom-team

app/code/Magento/Catalog/view/frontend/web/js/product/storage/data-storage.js

@@ -228,7 +228,7 @@ define([
             this.updateRequestConfig.data = queryBuilder.buildQuery(prepareAjaxParams);
             this.updateRequestConfig.data['store_id'] = store;
             this.updateRequestConfig.data['currency_code'] = currency;
-            $.ajax(this.updateRequestConfig).success(function (data) {
+            $.ajax(this.updateRequestConfig).done(function (data) {
                 this.request = {};
                 this.providerHandler(getParsedDataFromServer(data));
             }.bind(this));

app/code/Magento/ConfigurableProduct/view/adminhtml/templates/product/configurable/affected-attribute-set-selector/js.phtml

@@ -89,7 +89,7 @@
                             showLoader: true,
                             context: $form
                         })
-                            .success(function (data) {
+                            .done(function (data) {
                                 if (!data.error) {
                                     setAttributeSetId(data.id);
                                     closeDialogAndProcessForm($form);

app/code/Magento/ConfigurableProduct/view/adminhtml/web/js/variations/product-grid.js

@@ -95,7 +95,7 @@ define([
                 type: 'GET',
                 url: this._buildGridUrl(filterData),
                 context: $('body')
-            }).success(function (data) {
+            }).done(function (data) {
                 bootstrap(JSON.parse(data));
             });
         },

app/code/Magento/ConfigurableProduct/view/adminhtml/web/js/variations/variations.js

@@ -492,7 +492,7 @@ define([
                 dataType: 'json',
                 showLoader: true,
                 context: this
-            }).success(function (data) {
+            }).done(function (data) {
                 if (!data.error) {
                     this.set(
                         'skeletonAttributeSet',
@@ -507,7 +507,7 @@ define([
                 }
 
                 return false;
-            }).error(function (xhr) {
+            }).fail(function (xhr) {
                 if (xhr.statusText === 'abort') {
                     return;
                 }

app/code/Magento/Customer/Controller/Section/Load.php

@@ -64,8 +64,8 @@ public function execute()
     {
         /** @var \Magento\Framework\Controller\Result\Json $resultJson */
         $resultJson = $this->resultJsonFactory->create();
-        $resultJson->setHeader('Cache-Control', 'max-age=0, must-revalidate, no-cache, no-store');
-        $resultJson->setHeader('Pragma', 'no-cache');
+        $resultJson->setHeader('Cache-Control', 'max-age=0, must-revalidate, no-cache, no-store', true);
+        $resultJson->setHeader('Pragma', 'no-cache', true);
         try {
             $sectionNames = $this->getRequest()->getParam('sections');
             $sectionNames = $sectionNames ? array_unique(\explode(',', $sectionNames)) : null;

app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php

@@ -1498,6 +1498,10 @@ protected function _getAttributeConditionSql($attribute, $condition, $joinType =
                 $condition
             );
         } else {
+            if (isset($condition['null'])) {
+                $joinType = 'left';
+            }
+
             $this->_addAttributeJoin($attribute, $joinType);
             if (isset($this->_joinAttributes[$attribute]['condition_alias'])) {
                 $field = $this->_joinAttributes[$attribute]['condition_alias'];

app/code/Magento/Sales/Model/Order/ShipmentFactory.php

@@ -5,13 +5,13 @@
  */
 namespace Magento\Sales\Model\Order;
 
-use Magento\Framework\App\ObjectManager;
 use Magento\Framework\Exception\LocalizedException;
-use Magento\Sales\Model\Order\Shipment\ShipmentValidatorInterface;
 use Magento\Framework\Serialize\Serializer\Json;
 
 /**
  * Factory class for @see \Magento\Sales\Api\Data\ShipmentInterface
+ *
+ * @api
  */
 class ShipmentFactory
 {

app/code/Magento/Shipping/Controller/Adminhtml/Order/Shipment/NewAction.php

@@ -7,6 +7,7 @@
 namespace Magento\Shipping\Controller\Adminhtml\Order\Shipment;
 
 use Magento\Backend\App\Action;
+use Magento\Framework\App\ObjectManager;
 
 class NewAction extends \Magento\Backend\App\Action
 {
@@ -22,15 +23,24 @@ class NewAction extends \Magento\Backend\App\Action
      */
     protected $shipmentLoader;
 
+    /**
+     * @var \Magento\Shipping\Model\ShipmentProviderInterface
+     */
+    private $shipmentProvider;
+
     /**
      * @param Action\Context $context
      * @param \Magento\Shipping\Controller\Adminhtml\Order\ShipmentLoader $shipmentLoader
+     * @param \Magento\Shipping\Model\ShipmentProviderInterface $shipmentProvider
      */
     public function __construct(
         Action\Context $context,
-        \Magento\Shipping\Controller\Adminhtml\Order\ShipmentLoader $shipmentLoader
+        \Magento\Shipping\Controller\Adminhtml\Order\ShipmentLoader $shipmentLoader,
+        \Magento\Shipping\Model\ShipmentProviderInterface $shipmentProvider = null
     ) {
         $this->shipmentLoader = $shipmentLoader;
+        $this->shipmentProvider = $shipmentProvider ?: ObjectManager::getInstance()
+            ->get(\Magento\Shipping\Model\ShipmentProviderInterface::class);
         parent::__construct($context);
     }
 
@@ -43,7 +53,7 @@ public function execute()
     {
         $this->shipmentLoader->setOrderId($this->getRequest()->getParam('order_id'));
         $this->shipmentLoader->setShipmentId($this->getRequest()->getParam('shipment_id'));
-        $this->shipmentLoader->setShipment($this->getRequest()->getParam('shipment'));
+        $this->shipmentLoader->setShipment($this->shipmentProvider->getShipmentData());
         $this->shipmentLoader->setTracking($this->getRequest()->getParam('tracking'));
         $shipment = $this->shipmentLoader->load();
         if ($shipment) {

app/code/Magento/Shipping/Model/ShipmentProvider.php

@@ -0,0 +1,37 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\Shipping\Model;
+
+use Magento\Framework\App\RequestInterface;
+
+/**
+ * @inheritdoc
+ */
+class ShipmentProvider implements ShipmentProviderInterface
+{
+    /**
+     * @var RequestInterface
+     */
+    private $request;
+
+    /**
+     * @param RequestInterface $request
+     */
+    public function __construct(RequestInterface $request)
+    {
+        $this->request = $request;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getShipmentData(): array
+    {
+        return $this->request->getParam('shipment', []);
+    }
+}

app/code/Magento/Shipping/Model/ShipmentProviderInterface.php

@@ -0,0 +1,23 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\Shipping\Model;
+
+/**
+ * Provide shipment items data.
+ *
+ * @api
+ */
+interface ShipmentProviderInterface
+{
+    /**
+     * Retrieve shipment items.
+     *
+     * @return array
+     */
+    public function getShipmentData(): array;
+}