788: Integration test rework. Shipment controller refactor.

Author: nmalevanec

app/code/Magento/Shipping/Controller/Adminhtml/Order/Shipment/NewAction.php

@@ -7,6 +7,7 @@
 namespace Magento\Shipping\Controller\Adminhtml\Order\Shipment;
 
 use Magento\Backend\App\Action;
+use Magento\Framework\App\ObjectManager;
 
 class NewAction extends \Magento\Backend\App\Action
 {
@@ -35,10 +36,11 @@ class NewAction extends \Magento\Backend\App\Action
     public function __construct(
         Action\Context $context,
         \Magento\Shipping\Controller\Adminhtml\Order\ShipmentLoader $shipmentLoader,
-        \Magento\Shipping\Model\ShipmentProviderInterface $shipmentProvider
+        \Magento\Shipping\Model\ShipmentProviderInterface $shipmentProvider = null
     ) {
         $this->shipmentLoader = $shipmentLoader;
-        $this->shipmentProvider = $shipmentProvider;
+        $this->shipmentProvider = $shipmentProvider ?: ObjectManager::getInstance()
+            ->get(\Magento\Shipping\Model\ShipmentProviderInterface::class);
         parent::__construct($context);
     }
 

app/code/Magento/Shipping/Model/ShipmentProvider.php

@@ -30,7 +30,7 @@ public function __construct(RequestInterface $request)
     /**
      * @inheritdoc
      */
-    public function getShipment(): array
+    public function getShipmentData(): array
     {
         return $this->request->getParam('shipment', []);
     }

app/code/Magento/Shipping/Model/ShipmentProviderInterface.php

@@ -8,16 +8,16 @@
 namespace Magento\Shipping\Model;
 
 /**
- * Provide shipment items data from request.
+ * Provide shipment items data.
  *
  * @api
  */
 interface ShipmentProviderInterface
 {
     /**
-     * Retrieve shipment items from request.
+     * Retrieve shipment items.
      *
      * @return array
      */
-    public function getShipment(): array;
+    public function getShipmentData(): array;
 }