899: lineMarkerXmltag Decorator#checkadd #909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bohdan-harniuk
requested changes
Jan 6, 2022
There was a problem hiding this comment.
Hello, @artemii-karkusha!
Thank you for your work!
Please, check my questions and suggestions.
Thank you!
src/com/magento/idea/magento2plugin/linemarker/xml/LineMarkerXmlTagDecorator.java
Outdated
Show resolved
Hide resolved
src/com/magento/idea/magento2plugin/linemarker/xml/LineMarkerXmlTagDecorator.java
Outdated
Show resolved
Hide resolved
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
bohdan-harniuk
requested changes
Jan 6, 2022
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
bohdan-harniuk
approved these changes
Jan 13, 2022
m2-community-project
bot
added
Progress: approved
and removed
Progress: changes requested
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
I think we have two variants. We should set this method how deprecated and never use xmlTag.checkAdd() or create another realisation for it. I found service CheckUtil which has realisation checkWritable (similar checkAdd) for PsiElement.
Fixed Issues (if relevant)
Contribution checklist (*)