Skip to content

858: error correction in case entered fields is zero #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2021
Merged

858: error correction in case entered fields is zero #859

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a00d39a
858: error correction in case entered fields is zero
Iamwade Dec 17, 2021
cd06a38
Merge branch '4.2.2-develop' of github.com:magento/magento2-phpstorm-…
bohdan-harniuk Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...om/magento/idea/magento2plugin/actions/generation/generator/UiComponentFormGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,14 @@ protected PsiFile createForm(
protected void fillAttributes(final @NotNull Properties attributes) {
final PhpClassTypesBuilder phpClassTypesBuilder = new PhpClassTypesBuilder();

if (data.getFields().isEmpty()) {
phpClassTypesBuilder
.appendProperty("PRIMARY_FIELD", "");
} else {
phpClassTypesBuilder
.appendProperty("PRIMARY_FIELD", data.getFields().get(0).getName());
}

phpClassTypesBuilder
.appendProperty("NAME", data.getFormName())
.appendProperty("LABEL", data.getLabel())
Expand All @@ -165,7 +173,6 @@ protected void fillAttributes(final @NotNull Properties attributes) {
data.getDataProviderPath()
).getClassFqn()
)
.appendProperty("PRIMARY_FIELD", data.getFields().get(0).getName())
.mergeProperties(attributes);
}

Expand Down