Fixed Java.lang.IllegalArgumentException During adding a new method…
#580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into an existing plugin Adjusted plugin logo
…plugin into 576-`Java.lang.IllegalArgumentException`_During_adding_a_new_method_into_an_existing_plugin � Conflicts: � CHANGELOG.md
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
eduard13
approved these changes
Apr 28, 2021
eduard13
left a comment
eduard13
left a comment
There was a problem hiding this comment.
Thank you @VitaliyBoyko for the fix. Unfortunately, I wasn't able to reproduce it in my IntelliJ, but was able to reproduce it in one of my Projects.
But the fix makes sense 👍
VitaliyBoyko
deleted the
576-`Java.lang.IllegalArgumentException`_During_adding_a_new_method_into_an_existing_plugin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… into an existing plugin
Adjusted plugin logo
I've improved the class comparisons during sorting, made them based on the full file name to avoid doubling.
See the linked issue for more context.