Skip to content

Enhabced validation, added filtering for fields to validate on entity… #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2021
Merged

Enhabced validation, added filtering for fields to validate on entity… #524

merged 2 commits into from
Apr 2, 2021

Conversation

bohdan-harniuk
Copy link
Collaborator

Description (*)
What was done:

  1. validation extracted out of abstract dialog (composition over inheritance)
  2. enhanced validation process, simplified
  3. added filtering for fields to validate on entity creator dialog

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@eduard13 eduard13 self-assigned this Apr 2, 2021
eduard13
eduard13 requested changes Apr 2, 2021
View reviewed changes
@eduard13 eduard13 merged commit faa2ce6 into magento:mainline-entity-manager Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eduard13 eduard13 eduard13 approved these changes

Assignees

@eduard13 eduard13

Labels

Medium Partner: Atwix partners-contribution Progress: done QA passed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bohdan-harniuk @eduard13 @magento-engcom-team