502: Fixed - Class completion doesn't display interfaces. #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 10, 2021 15:08
…plugin into 502-Class_completion_doesn't_display_interfaces
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
VitaliyBoyko
commented
Mar 10, 2021
| interfaceNames.removeIf(i -> !i.contains(className)); | ||
| for (String iName: interfaceNames) { | ||
| final Collection<String> interfaceNames = phpIndex.getAllInterfaceNames(); | ||
| interfaceNames.removeIf(i -> !i.contains(className.toLowerCase(Locale.ROOT))); |
There was a problem hiding this comment.
This line makes the difference, others are static fixes
eduard13
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Test on actual project.
Fixed Issues (if relevant)
Questions or comments
ℹ️ In order to apply the fix, the reindexing has to be run.
Contribution checklist (*)