Skip to content

Conversation

VitaliyBoyko
Copy link
Contributor

@VitaliyBoyko VitaliyBoyko commented Feb 27, 2021

The plugin is dependent on native libraries and requires to restart on update:
https://plugins.jetbrains.com/docs/intellij/dynamic-plugins.html?from=jetbrains.org

Behavior can be tested during the live update only.

Fixed Issues (if relevant)

  1. Fixes Error when open project #498

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@VitaliyBoyko
Copy link
Contributor Author

Linux tests :( nothing easy

@eduard13 eduard13 added the Easy label Mar 1, 2021
@VitaliyBoyko
Copy link
Contributor Author

@eduard13 the reason of failing tests was in singletons and cached global object within them

@eduard13 eduard13 added the Medium label Mar 9, 2021
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👏 .
Skeletons 🤯

@VitaliyBoyko VitaliyBoyko merged commit 02bb789 into 3.1.3-develop Mar 9, 2021
@VitaliyBoyko VitaliyBoyko deleted the require-restart-on-plugin-update branch March 9, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants