Skip to content

Conversation

bohdan-harniuk
Copy link
Collaborator

Description (*)
What was done:

  1. Column Attributes extracted to the enum type, added default values for them
  2. Code refactoring after ColumnAttributes enum was added
  3. Added possibility to create expected in the generators columns data from entity properties data
  4. Added test coverage for the new feature
  5. Code refactoring in the related files
  6. Testing in the local env.

Results:
Screenshot 2021-01-22 at 01 05 27
Screenshot 2021-01-22 at 01 05 18
Screenshot 2021-01-22 at 01 01 18
Screenshot 2021-01-22 at 01 00 08

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

…ora1004/magento2-phpstorm-plugin into provide-declarative-schema-features-to-entity-manager
… with provided entity properties instead of columns data
…-phpstorm-plugin into provide-declarative-schema-features-to-entity-manager
@VitaliyBoyko VitaliyBoyko merged commit c035056 into magento:mainline-entity-manager Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants