Skip to content

Added generate models action #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 23, 2020
Merged

Added generate models action #392

merged 8 commits into from
Nov 23, 2020

Conversation

VitaliyBoyko
Copy link
Contributor

@VitaliyBoyko VitaliyBoyko commented Nov 13, 2020 •
edited by coderimus
Loading

Description (*)
Added action for generating DB models such as Model, Resource Model and Collection.
image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Merge branch '2.1.0-develop' of github.com:magento/magento2-phpstorm-…
5b3cc7c 
…plugin into models-generation

� Conflicts:
�	resources/META-INF/plugin.xml
�	src/com/magento/idea/magento2plugin/magento/files/FormButtonBlockPhp.java
@coderimus coderimus self-assigned this Nov 13, 2020
@coderimus coderimus self-requested a review November 13, 2020 16:44
@drpayyne
Copy link
Contributor

Hi @VitaliyBoyko, a small suggestion: can you please rename the template files by removing the word Module from all of it? This is for the sake of consistency and concise naming. Thank you!

@coderimus coderimus merged commit 42e4954 into 2.1.0-develop Nov 23, 2020
@VitaliyBoyko VitaliyBoyko deleted the models-generation branch November 23, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@coderimus coderimus coderimus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@coderimus coderimus

Labels

Advanced Award: test coverage Partner: Atwix partners-contribution Progress: approved Progress: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@VitaliyBoyko @drpayyne @coderimus @magento-engcom-team