Skip to content

Covered PhpJobMethodReferenceProvider with tests #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2020
Merged

Covered PhpJobMethodReferenceProvider with tests #391

merged 2 commits into from
Nov 13, 2020

Conversation

@drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Nov 12, 2020 •
edited
Loading

Description

Added test coverage for PhpJobMethodReferenceProvider

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@drpayyne drpayyne changed the title Covered EventNameReferenceProvider with tests Covered PhpJobMethodReferenceProvider with tests Nov 12, 2020
@VitaliyBoyko VitaliyBoyko merged commit 4bf8869 into magento:2.1.0-develop Nov 13, 2020
@VitaliyBoyko
Copy link
Contributor

VitaliyBoyko commented Nov 13, 2020

Awesome job 💖

@drpayyne
Copy link
Contributor Author

drpayyne commented Nov 14, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VitaliyBoyko VitaliyBoyko VitaliyBoyko approved these changes

Assignees

@VitaliyBoyko VitaliyBoyko

Labels

Award: test coverage partners-contribution Progress: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drpayyne @VitaliyBoyko @magento-engcom-team