Changed validator for NewCLICommandDialog #338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed validator for
com.magento.idea.magento2plugin.actions.generation.dialog.NewCLICommandDialogFixed Issues
Additional changes
CliCommandRuleto validate command CLI command formatsnotEmptyvalidation doesn't work for aJTextAreafieldisPHPClassValid()method from validator to main class to validate if the PHP class already exists.Questions
isPHPClassValid()inside the existingPhpClassRuleclass? We'll need to reuse this in various placesCLI commandalready exists, just like a PHP class. I'm thinking this is needed since there can't be two identical commands doing different things. What do you think?Contribution checklist