Changed validator for InjectAViewModelDialog #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderimus
approved these changes
Oct 23, 2020
drpayyne
commented
Oct 30, 2020
| common.name=Name | ||
| common.className=Class Name | ||
| common.className=Class name | ||
| common.argument=Argument name |
Contributor
Author
There was a problem hiding this comment.
Hey @VitaliyBoyko, @coderimus. I was just doing some local testing and I noticed that this line (line 26) with the value for common.argument is missing from the current codebase? This PR was merged but this particular file doesn't seem to be 'registered' in the git commit history? I'm very confused, maybe I'm missing something. Could you please check on this? Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the validator for
com.magento.idea.magento2plugin.actions.generation.dialog.InjectAViewModelDialogand fixes some grammarFixed Issues
Contribution checklist