Skip to content

Fixing the dialog size. Fixing adding new form fieldset #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 22, 2020
Merged

Fixing the dialog size. Fixing adding new form fieldset #323

merged 5 commits into from
Oct 22, 2020

Conversation

@eduard13
Copy link
Contributor

@eduard13 eduard13 commented Oct 21, 2020

Description (*)
This PR fixes couple of issues related to Ui form generation:

  • Fixed the modal size ✅
  • Fixed the Sort Order value for fieldset row ✅

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@eduard13 eduard13 changed the base branch from 2.1.0-develop to 2.0.0-develop October 21, 2020 12:21
@eduard13 eduard13 requested a review from VitaliyBoyko October 21, 2020 12:22
@VitaliyBoyko VitaliyBoyko self-assigned this Oct 21, 2020
@VitaliyBoyko VitaliyBoyko merged commit 0256104 into magento:2.0.0-develop Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VitaliyBoyko VitaliyBoyko VitaliyBoyko approved these changes

Assignees

@VitaliyBoyko VitaliyBoyko

Labels

Easy Partner: Atwix partners-contribution

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eduard13 @VitaliyBoyko @magento-engcom-team