Updated Gradle Intellij plugin to version 2 [WIP] #2473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le-to-version-2 # Conflicts: # build.gradle
This commit introduces a new `ruleset.xml` file for PMD, specifying custom rules and exclusions tailored for Magento's codebase. It ensures consistency in code quality by excluding irrelevant checks and focusing on important patterns. This configuration is critical for integrating automated code analysis into the project.
This commit introduces a `.phpstorm.meta.php` file to improve developer experience with dependency injection autocomplete in Magento. It maps common classes, arguments, and expected values, enhancing code completion and reducing errors during development.
The file was renamed in the same directory to align with naming conventions and improve readability. This change does not alter functionality but helps maintain a more organized structure.
Adjusted file paths for various XML test data files to ensure consistency and proper organization. This includes updates to completion, reference, generation, and inspection test cases across multiple domains.
Replaced `fillDefaultProperties` method with direct property merging for cleaner code and removed unused imports. Updated Gradle dependencies to JUnit 5.10.0 and excluded specific test paths while enabling `useJUnitPlatform()` for improved test management.
Applied the `staticChecks.gradle` script to enforce static code analysis during the build process. This integration helps maintain code quality and consistency across the project.
Moved static check configurations (Checkstyle and PMD) from the `staticChecks.gradle` script into `build.gradle.kts`. This centralizes Gradle setup into one file and leverages Kotlin DSL for better type safety and maintainability.
Upgraded Gradle IntelliJ plugin to version 2, enabling support for IntelliJ IDEA Community edition and eliminating the need for the Ultimate edition. Also refined the publishing token environment variable for better clarity and consistency.
VitaliyBoyko
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request upgrades the Gradle IntelliJ Plugin to version 2, introducing significant improvements and updates for better compatibility, usability, and adherence to modern standards.
Key Changes
Removal of Paid Ultimate Version Requirements:
The project no longer requires the paid Ultimate edition of IntelliJ IDEA. It can now run seamlessly in the Community edition.
Adoption of Latest Best Practices:
Updated to align with the latest best practices introduced in the official IntelliJ Plugin Template repository.
Enhanced PHPStorm Compatibility:
Enabled code emulation directly within PHPStorm, eliminating the dependency on IntelliJ IDEA for this functionality.
Modernization and Maintenance:
Ensures the project remains up-to-date with the latest plugin versions and development standards.