Skip to content

Fix NewObserverDialog form typo #2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Fix NewObserverDialog form typo #2087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/com/magento/idea/magento2plugin/actions/generation/dialog/NewObserverDialog.form
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,12 @@
<text value="Directory Path"/>
</properties>
</component>
<component id="58ad9" class="javax.swing.JLabel" binding="evenNamesLabel">
<component id="58ad9" class="javax.swing.JLabel" binding="eventNamesLabel">
<constraints>
<grid row="7" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
</constraints>
<properties>
<text value="Observer Even Name"/>
<text value="Observer Event Name"/>
</properties>
</component>
<component id="be834" class="javax.swing.JLabel" binding="directoryStructureErrorMessage">
Expand Down
8 changes: 4 additions & 4 deletions src/com/magento/idea/magento2plugin/actions/generation/dialog/NewObserverDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public class NewObserverDialog extends AbstractDialog {
private JLabel classNameErrorMessage;// NOPMD
private JLabel directoryStructureLabel;// NOPMD
private JLabel directoryStructureErrorMessage;// NOPMD
private JLabel evenNamesLabel;// NOPMD
private JLabel eventNamesLabel;// NOPMD
private JLabel targetAreaLabel;// NOPMD

/**
Expand Down Expand Up @@ -186,7 +186,7 @@ public String getClassName() {
return className.getText().trim();
}

public String getEvenName() {
public String getEventName() {
return eventName.getSelectedItem().toString();
}

Expand All @@ -213,7 +213,7 @@ protected void onOK() {
modulePackage,
moduleName,
getObserverClassFqn(),
getEvenName(),
getEventName(),
observerDirectory,
ModuleObserverFile.resolveClassNameFromInput(getClassName())
),
Expand All @@ -227,7 +227,7 @@ protected void onOK() {
Package.fqnSeparator,
Package.vendorModuleNameSeparator
),
getEvenName(),
getEventName(),
getObserverName(),
getObserverClassFqn().concat(Package.fqnSeparator).concat(
ModuleObserverFile.resolveClassNameFromInput(getClassName())
Expand Down