Skip to content

1113: Fixed IllegalArgumentException: Argument for @NotNull parameter 'dataKey' must not be null in CompareTemplateAction #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2022
Merged

1113: Fixed IllegalArgumentException: Argument for @NotNull parameter 'dataKey' must not be null in CompareTemplateAction #1117

merged 2 commits into from
Jun 17, 2022

Conversation

Iamwade
Copy link
Collaborator

@Iamwade Iamwade commented Jun 17, 2022

Description (*)
Fixed a bug that caused a bug when comparing files

  1. Fixes [Bug] IllegalArgumentException: Argument for @NotNull parameter 'dataKey' must not be null in CompareTemplateAction #1113

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@bohdan-harniuk bohdan-harniuk self-assigned this Jun 17, 2022
@bohdan-harniuk bohdan-harniuk self-requested a review June 17, 2022 17:34
@bohdan-harniuk bohdan-harniuk changed the title 1113: Fixed not null parameter 1113: Fixed IllegalArgumentException: Argument for @NotNull parameter 'dataKey' must not be null in CompareTemplateAction Jun 17, 2022
bohdan-harniuk
bohdan-harniuk approved these changes Jun 17, 2022
View reviewed changes
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Iamwade, for your work here!

@bohdan-harniuk bohdan-harniuk merged commit 8ecd5c9 into magento:4.4.0-develop Jun 17, 2022
@SilinMykola SilinMykola mentioned this pull request Jul 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bohdan-harniuk bohdan-harniuk bohdan-harniuk approved these changes

Assignees

@bohdan-harniuk bohdan-harniuk

Labels

bug Partner: Atwix partners-contribution Progress: approved Progress: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] IllegalArgumentException: Argument for @NotNull parameter 'dataKey' must not be null in CompareTemplateAction

2 participants

@Iamwade @bohdan-harniuk