Skip to content

Conversation

doninAtwix
Copy link
Contributor

@doninAtwix doninAtwix commented Mar 23, 2022

Description (*)

Eliminated usage of deprecated method Function#getReturnType for class com.magento.idea.magento2plugin.actions.generation.util.FillTextBufferWithPluginMethods.
This functionality works when creating a plugin from the context menu.

plugin-create-001_Z4FtDQaY.mp4

Type bool:
Screenshot 2022-03-24 at 15 20 07
Screenshot 2022-03-24 at 15 20 23
Screenshot 2022-03-24 at 15 21 35

Type int:
Screenshot 2022-03-24 at 15 56 47
Screenshot 2022-03-24 at 15 58 42
Screenshot 2022-03-24 at 16 00 02

Type string:
Screenshot 2022-03-24 at 16 07 05
Screenshot 2022-03-24 at 16 05 51
Screenshot 2022-03-24 at 16 05 38

Type array:
Screenshot 2022-03-24 at 16 14 02
Screenshot 2022-03-24 at 16 14 17
Screenshot 2022-03-24 at 16 14 30

Type void:
Screenshot 2022-03-24 at 16 25 04
Screenshot 2022-03-24 at 16 25 15
Screenshot 2022-03-24 at 16 25 29

Type string with params:
Screenshot 2022-03-24 at 16 29 15
Screenshot 2022-03-24 at 16 30 17
Screenshot 2022-03-24 at 16 31 11

Type array with params:
Screenshot 2022-03-24 at 17 21 19
Screenshot 2022-03-24 at 17 22 17
Screenshot 2022-03-24 at 17 23 13

Type string with param string:
Screenshot 2022-03-24 at 17 32 22
Screenshot 2022-03-24 at 17 32 36
Screenshot 2022-03-24 at 17 32 45

Fixed Issues (if relevant)

  1. Fixes Eliminate deprecated Function#getReturnType method usage #1035

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@bohdan-harniuk bohdan-harniuk force-pushed the 1035-remove-deprecated-function-getreturntype-methond-usage branch from a202fab to 8d52fd1 Compare March 24, 2022 10:37
…plugin into 1035-remove-deprecated-function-getreturntype-methond-usage
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @doninAtwix!

Great work!
Thank you!

Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eliminate deprecated Function#getReturnType method usage

2 participants