1023: Added an additional path field for UCT configuration dialog (to cover theme folder scanning) #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bohdan-harniuk merged 2 commits into magento:mainline/uct-1023-theme-scanning-feature from doninAtwix:1023-add-configure-option

Mar 7, 2022

Contributor

doninAtwix commented Mar 4, 2022 •

edited by bohdan-harniuk

Loading

Description (*)

Added additional fields to UCT configuration dialog. When you click on checkbox "Add additional path to analyse" an additional field "Path To Analyse" will become available for selection.

Fixed Issues (if relevant)

Fixes [UCT] Cover themes scanning/reporting for the Tools > Run The Upgrade Compatibility Tool #1023

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with integration/functional tests (if applicable)
All automated tests passed successfully (all builds are green)


          1023: Added additional fields for UCT configuration dialog

11606af

bohdan-harniuk self-requested a review

March 5, 2022 15:03

bohdan-harniuk self-assigned this

m2-community-project bot added the Progress: review label

bohdan-harniuk added Partner: Atwix partners-contribution and removed Progress: review labels

m2-community-project bot added Progress: on hold Progress: review labels

bohdan-harniuk requested changes

View reviewed changes

Collaborator

bohdan-harniuk left a comment

Hello, @doninAtwix!

Please, check my notices.

Regards,

src/com/magento/idea/magento2uct/ui/ConfigurationDialog.java

    
              import javax.swing.JLabel;

              import javax.swing.JPanel;

              import javax.swing.KeyStroke;

              import javax.swing.*;

Collaborator

bohdan-harniuk Mar 5, 2022

Please, do not use wildcard imports.

Contributor Author

doninAtwix Mar 5, 2022

Thanks for your code review. I fixed. Please check.

src/com/magento/idea/magento2uct/ui/ConfigurationDialog.java Outdated

    
                  private JLabel modulePathError;//NOPMD

                  private JLabel enableComment;//NOPMD

                  private JLabel enableCommentPath;//NOPMD

                  private JCheckBox hasAdditionalPath;

Collaborator

bohdan-harniuk Mar 5, 2022

Please, keep labels separately from other elements. Move this one ☝️

Contributor Author

doninAtwix Mar 5, 2022

Thanks for your code review. I fixed. Please check.

src/com/magento/idea/magento2uct/ui/ConfigurationDialog.java Outdated

    
                          final String basePath = Settings.getMagentoPath(project);

                          if (basePath != null) {

                              additionalPath.getComponent().setText(basePath);

Collaborator

bohdan-harniuk Mar 5, 2022

Why did you do that? What is business goal here?

Contributor Author

doninAtwix Mar 5, 2022

Hi @bohdan-harniuk , the functionality was duplicated as for the field modulePath so that you can specify an additional path

Contributor Author

doninAtwix Mar 5, 2022

Thanks for your code review. I fixed. Please check.

src/com/magento/idea/magento2uct/ui/ConfigurationDialog.java

    
                  }

                  private void refreshAdditionalFields(final boolean isEnabled) {

                      additionalPath.setEnabled(isEnabled);

Collaborator

bohdan-harniuk Mar 5, 2022

You can add additionalPath.setVisible(isEnabled);

Contributor Author

doninAtwix Mar 5, 2022

Thanks for your code review. I fixed. Please check.

src/com/magento/idea/magento2uct/ui/ConfigurationDialog.java

    
                      setTitle(ConfigureUctAction.ACTION_NAME);

                      getRootPane().setDefaultButton(buttonOk);

                      hasAdditionalPath.addActionListener(event -> refreshAdditionalFields(hasAdditionalPath.isSelected()));

Collaborator

bohdan-harniuk Mar 5, 2022

Please, call this method refreshAdditionalFields in the constructor. So we will get saved state of this component.

Collaborator

bohdan-harniuk Mar 5, 2022

Pay attention, this method should be called after setDefaultValues.

Contributor Author

doninAtwix Mar 5, 2022

Thanks for your code review. I fixed. Please check.

m2-community-project bot added Progress: changes requested Progress: review and removed Progress: review Progress: on hold Progress: changes requested labels


          1023: update logic and code style

a17258a

Contributor Author

doninAtwix commented Mar 5, 2022

Updated logic, now when you click on checkbox "Add additional path to analyse" an additional field "Path To Analyse" has show/hide effect.

bohdan-harniuk changed the title ~~1023: Added additional fields for UCT configuration dialog~~ 1023: Added an additional path field for UCT configuration dialog (to cover theme folder scanning)

bohdan-harniuk approved these changes

View reviewed changes

Collaborator

bohdan-harniuk left a comment

Great work!
Thank you, @doninAtwix!

m2-community-project bot added Progress: approved and removed Progress: review labels

bohdan-harniuk merged commit 267b88c into magento:mainline/uct-1023-theme-scanning-feature

m2-community-project bot added Progress: done and removed Progress: approved labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner: Atwix partners-contribution Progress: done