Skip to content

Conversation

bhennesAdv
Copy link

@see magento/magento2#38565 for issue description

I'm not doing typescript at all, so I just ported the same correction as it would probably not crash.
Maybe the template function get() automatically casts the returned value to string to it might be overkill.

I let typescript experts judge on this.

bhennesAdv and others added 2 commits June 24, 2025 10:33
@engcom-Hotel
Copy link
Collaborator

@magento run all tests

Copy link
Collaborator

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bhennesAdv,

Thanks for the contribution!

Please fix the failed automated test.

Thanks

@bhennesAdv
Copy link
Author

@magento run all tests

@engcom-Hotel
Copy link
Collaborator

Hello @bhennesAdv,

It seems you are still working on it, hence moving this PR On Hold and mark it as draft. Please let us know whenever the PR will be ready for further processing.

Thanks

@bhennesAdv
Copy link
Author

Hello @engcom-Hotel

I would say that everything is finished as static tests are now OK (It was the only issue when I looked at it).
I'll start the functional tests again to see if the issue is on my side or in the main branch...

I'll let you know if all tests passed or I'll check it if there is some issues.

@engcom-Hotel engcom-Hotel moved this from Ready for Review to On Hold in Pull Request Progress - PageBuilder Jul 17, 2025
@engcom-Hotel engcom-Hotel marked this pull request as draft July 17, 2025 13:16
@engcom-Hotel
Copy link
Collaborator

Hello @bhennesAdv,

Have you got a chance to look into this PR?

Thanks

@bhennesAdv
Copy link
Author

Hello @engcom-Hotel,

I did the modification but I was waiting for automated test to validate the content.

I just updated the branch with latest develop changes.
Can you force the test to run ?

Kind Regards,
Baptiste

@engcom-Hotel
Copy link
Collaborator

@magento run all tests

@engcom-Hotel
Copy link
Collaborator

Hello @bhennesAdv,

It seems some automated tests are failing due to the PR changes. Please refer to the test reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants