Skip to content

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Dec 14, 2019

Description

  • Added clarity in the differences between / and // XPath selector syntax

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-engcom-team magento-engcom-team added partners-contribution Pull Request is created by Magento Partner Partner: Zilker Technology labels Dec 14, 2019
@coveralls
Copy link

coveralls commented Dec 14, 2019

Coverage Status

Coverage decreased (-0.6%) to 52.022% when pulling 96b7249 on drpayyne:patch-1 into 4f482ce on magento:master.

@KevinBKozan
Copy link
Contributor

@drpayyne thank you for your contribution! I'll go ahead and review this.

@KevinBKozan
Copy link
Contributor

@drpayyne I added one commit to this just to add backticks around the in-line HTML, and modified the last sentence just a little bit.

Overall a good addition, thanks again for your contribution 👍

KevinBKozan
KevinBKozan previously approved these changes Dec 20, 2019
@KevinBKozan KevinBKozan merged commit 632ac7d into magento:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner: Zilker Technology partners-contribution Pull Request is created by Magento Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants