Skip to content

PHP 8.1 Compatibility #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2022
Merged

PHP 8.1 Compatibility #366

merged 1 commit into from
Feb 9, 2022

Conversation

sivaschenko
Copy link
Member

@sivaschenko sivaschenko commented Feb 8, 2022 •
edited
Loading

Preventing the error appearing on PHP 8.1:

------------------------------------------------------------------------------------------------------------------------------------------------------
 1 | ERROR | An error occurred during processing; checking has been aborted. The error message was: trim(): Passing null to parameter #1 ($string) of
   |       | type string is deprecated in
   |       | /Users/sivashch/Projects/magento-coding-standard/vendor/phpcompatibility/php-compatibility/PHPCompatibility/Sniff.php on line 131
------------------------------------------------------------------------------------------------------------------------------------------------------

Test builds sensitivity improved in #367

Fixes https://jira.corp.magento.com/browse/AC-2349

@sivaschenko sivaschenko mentioned this pull request Feb 8, 2022
Merged
@sivaschenko
Copy link
Member Author

@magento import pr to magento-commerce/magento-coding-standard

@m2-github-services
Copy link
Contributor

@sivaschenko the Pull Request is successfully imported.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 03d5751 into magento:develop Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@svera svera svera approved these changes

@eliseacornejo eliseacornejo eliseacornejo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@svera svera

@eliseacornejo eliseacornejo

Labels
Progress: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sivaschenko @m2-github-services @svera @eliseacornejo @magento-devops-reposync-svc