Skip to content

AC-1059: Move PHPCompatibility rules from Magento tests #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 19, 2021
Merged

AC-1059: Move PHPCompatibility rules from Magento tests #332

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1b2153f
AC-1059: Move PHPCompatibility rules from Magento tests
svera Nov 15, 2021
1d3fa20
AC-1059: Move PHPCompatibility rules from Magento tests
svera Nov 15, 2021
c01fed6
AC-1059: Move PHPCompatibility rules from Magento tests
svera Nov 16, 2021
7059a4b
AC-1059: Move PHPCompatibility rules from Magento tests
svera Nov 16, 2021
168882e
AC-1059: Added minimal supported PHP version to PHPCompatibility
svera Nov 18, 2021
551fd7a
Merge branch 'develop' of github.com:magento/magento-coding-standard …
svera Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Magento2/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,4 +737,7 @@
<rule ref="Internal.NoCodeFound">
<severity>0</severity>
</rule>
<rule ref="PHPCompatibility">
<exclude name="PHPCompatibility.Miscellaneous.RemovedAlternativePHPTags.MaybeASPOpenTagFound" />
</rule>
</ruleset>
9 changes: 5 additions & 4 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,11 @@
"version": "15",
"require": {
"php": ">=7.3",
"squizlabs/php_codesniffer": "^3.6",
"webonyx/graphql-php": "^14.9",
"ext-simplexml": "*",
"ext-dom": "*"
"ext-dom": "*",
"phpcompatibility/php-compatibility": "^9.3",
"squizlabs/php_codesniffer": "^3.6"
},
"require-dev": {
"phpunit/phpunit": "^9.5.8"
Expand All @@ -32,7 +33,7 @@
}
},
"scripts": {
"post-install-cmd": "vendor/bin/phpcs --config-set installed_paths ../../..",
"post-update-cmd": "vendor/bin/phpcs --config-set installed_paths ../../.."
"post-install-cmd": "vendor/bin/phpcs --config-set installed_paths ../../..,../../phpcompatibility/php-compatibility/PHPCompatibility",
"post-update-cmd": "vendor/bin/phpcs --config-set installed_paths ../../..,../../phpcompatibility/php-compatibility/PHPCompatibility"
}
}
90 changes: 76 additions & 14 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.