Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

Conversation

@strell
Copy link
Contributor

@strell strell commented Sep 21, 2019

Description

  • Added new column order_number with the type of String!
  • Changed the api_functional test in order to test a new field

Fixed Issues

  1. [Checkout] Rename increment_id for CustomerOrder type #878: [Checkout] Rename increment_id for CustomerOrder type

Manual testing scenarios

See issue description

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

 - Added new column order_number with the type of String!
 - Changed the api_functional test in order to test a new field
@strell strell requested a review from paliarush as a code owner September 21, 2019 11:57
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 21, 2019

CLA assistant check
All committers have signed the CLA.

@strell strell requested a review from okorshenko September 22, 2019 07:33
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-5930 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ghost
Copy link

ghost commented Sep 25, 2019

Hi @strell, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants