Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

graphQl-903: deprecated use_for_shipping in billing address schema #943

Merged
merged 9 commits into from
Oct 31, 2019
Merged

graphQl-903: deprecated use_for_shipping in billing address schema #943

merged 9 commits into from
Oct 31, 2019

Conversation

@VitaliyBoyko
Copy link
Contributor

@VitaliyBoyko VitaliyBoyko commented Sep 18, 2019

Fixed Issues (if relevant)

  1. [Checkout] Replace use_for_shipping with same_as_shipping #903: [Checkout] Replace use_for_shipping with same_as_shipping

lenaorobei
lenaorobei reviewed Sep 18, 2019
View reviewed changes
@VitaliyBoyko VitaliyBoyko added Contribution Day Tickets is good for start on Contribution Day Event: mageconf19 MageConf 2019 Contribution Day labels Sep 27, 2019
lenaorobei
lenaorobei reviewed Sep 27, 2019
View reviewed changes
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 27, 2019

Hi @lenaorobei, thank you for the review.
ENGCOM-5963 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

lenaorobei
lenaorobei suggested changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the fact that use_for_shipping is deprecated we need to preserve its behaviour. It should be the same as same_as_shipping.

@ghost
Copy link

ghost commented Oct 2, 2019

Hi @VitaliyBoyko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@VitaliyBoyko VitaliyBoyko reopened this Oct 2, 2019
lenaorobei
lenaorobei reviewed Oct 7, 2019
View reviewed changes
...ests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/SetBillingAddressOnCartTest.php
telephone: "88776655"
save_in_address_book: false
}
use_for_shipping: true
Copy link
Contributor

@lenaorobei lenaorobei Oct 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep tests for both fields for now.

lenaorobei
lenaorobei suggested changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment about BC.

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 23, 2019

Hi @lenaorobei, thank you for the review.
ENGCOM-5963 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

magento-engcom-team pushed a commit that referenced this pull request Oct 31, 2019
@lenaorobei
ENGCOM-5963: graphQl-903: deprecated use_for_shipping in billing addr…
df5c5d9 
…ess schema #943
@magento-engcom-team magento-engcom-team merged commit bb25f9a into 2.3-develop Oct 31, 2019
@ghost
Copy link

ghost commented Oct 31, 2019

Hi @VitaliyBoyko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper keharper mentioned this pull request Nov 7, 2019
Merged
@okorshenko okorshenko deleted the GraphQl-903-deprecate-use-for-shipping branch December 18, 2019 22:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paliarush paliarush Awaiting requested review from paliarush

1 more reviewer

@lenaorobei lenaorobei lenaorobei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lenaorobei lenaorobei

Labels

approved Auto-Tests: Covered Component: QuoteGraphQl Contribution Day Tickets is good for start on Contribution Day documentation-completed Event: mageconf19 MageConf 2019 Contribution Day Partner: Atwix partners-contribution Release Line: 2.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@VitaliyBoyko @magento-engcom-team @lenaorobei @keharper