This repository was archived by the owner on Dec 19, 2019. It is now read-only.
MC-19746: The shipping address contains null values when there's no…
#906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… shipping address set on a cart - return null instead of fields when there's no selected method
Contributor
|
|
…ing-address-when-it-not-set' into MC-19746
… shipping address set on a cart - remove condition because it not the correct condition
… shipping address set on a cart - add validator to check if address was set
… shipping address set on a cart - fix variable initialization
… shipping address set on a cart - fix tests
… shipping address set on a cart - fix changes to also apply to 2.3.2
… shipping address set on a cart - fix test
… shipping address set on a cart - fix test
… shipping address set on a cart - fix test
# Conflicts: # app/code/Magento/QuoteGraphQl/Model/Resolver/ShippingAddress/SelectedShippingMethod.php # dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/GetSelectedShippingMethodTest.php
Contributor
|
@magento run all tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… shipping address set on a cart
Description (*)
Fixed Issues (if relevant)
nullvalues when there's no shipping address set on a cart #864: The shipping address containsnullvalues when there's no shipping address set on a cartContribution checklist (*)