Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

graphQl-890: Replaced usage of the CartItemQuantity with the CartItem… #899

Merged
merged 11 commits into from
Oct 31, 2019
Merged

graphQl-890: Replaced usage of the CartItemQuantity with the CartItem… #899

merged 11 commits into from
Oct 31, 2019

Conversation

@VitaliyBoyko
Copy link
Contributor

@VitaliyBoyko VitaliyBoyko commented Sep 4, 2019

…Interface

Description (*)

Replaced usage of the CartItemQuantity with the CartItemInterface in the GraphQl scheme.

Fixed Issues (if relevant)

  1. [Checkout] Replace usage of CartItemQuantity with CartItemInterface #890: [Checkout] Replace usage of CartItemQuantity with CartItemInterface

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 4, 2019

Hi @lenaorobei, thank you for the review.
ENGCOM-5772 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

lenaorobei
lenaorobei suggested changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please pull latest changes from 2.3-develop

Merge branches '2.3-develop' and 'GraphQl-890-Replaced-usage-of-CartI…
94e8f14 
…temQuantity-with-CartItemInterface' of github.com:magento/graphql-ce into GraphQl-890-Replaced-usage-of-CartItemQuantity-with-CartItemInterface

# Conflicts:
#	app/code/Magento/QuoteGraphQl/etc/schema.graphqls
@VitaliyBoyko
Copy link
Contributor Author

VitaliyBoyko commented Sep 13, 2019

@lenaorobei Done

lenaorobei
lenaorobei suggested changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address comments.

app/code/Magento/QuoteGraphQl/etc/schema.graphqls Outdated
items_weight: Float
cart_items: [CartItemQuantity]
customer_notes: String
items_weight: Float @deprecated
Copy link
Contributor

@lenaorobei lenaorobei Sep 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add reason here.

app/code/Magento/QuoteGraphQl/etc/schema.graphqls Outdated
}

type CartItemQuantity {
type CartItemQuantity @deprecated(reason: "Use CartItemInterface instead") {
Copy link
Contributor

@lenaorobei lenaorobei Sep 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the ticket:

All fields in CartItemQuantity should be deprecated (so this type can be completely removed in the future releases)

Vitaliy Boyko added 2 commits September 27, 2019 10:24
Merge branches '2.3-develop' and 'GraphQl-890-Replaced-usage-of-CartI…
77e3a9c 
…temQuantity-with-CartItemInterface' of github.com:magento/graphql-ce into GraphQl-890-Replaced-usage-of-CartItemQuantity-with-CartItemInterface
graphQl-890: fixed deprecation messages
863d178
@VitaliyBoyko VitaliyBoyko added Contribution Day Tickets is good for start on Contribution Day Event: mageconf19 MageConf 2019 Contribution Day labels Sep 27, 2019
lenaorobei
lenaorobei suggested changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test case to check shipping_addresses field.

@magento-engcom-team magento-engcom-team mentioned this pull request Oct 31, 2019
Closed
magento-engcom-team pushed a commit that referenced this pull request Oct 31, 2019
@lenaorobei
ENGCOM-5772: graphQl-890: Replaced usage of the CartItemQuantity with…
9640575 
… the CartItem… #899
@magento-engcom-team magento-engcom-team merged commit b9f708b into 2.3-develop Oct 31, 2019
@ghost
Copy link

ghost commented Oct 31, 2019

Hi @VitaliyBoyko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper keharper mentioned this pull request Nov 6, 2019
Merged
@okorshenko okorshenko deleted the GraphQl-890-Replaced-usage-of-CartItemQuantity-with-CartItemInterface branch December 18, 2019 22:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paliarush paliarush Awaiting requested review from paliarush

1 more reviewer

@lenaorobei lenaorobei lenaorobei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lenaorobei lenaorobei

Labels

approved Auto-Tests: Covered Component: QuoteGraphQl Contribution Day Tickets is good for start on Contribution Day documentation-completed Event: mageconf19 MageConf 2019 Contribution Day Partner: Atwix partners-contribution Release Line: 2.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@VitaliyBoyko @magento-engcom-team @lenaorobei @keharper