This repository was archived by the owner on Dec 19, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 150
Add resolver to determine if quote is virtual #895
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
@magento run Functional Tests build, WebAPI Tests build |
Contributor
Author
|
@lenaorobei found the culprit. I had a wrong fixture path reference that caused |
paliarush
approved these changes
Sep 5, 2019
dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/GetCartIsVirtualTest.php
Outdated
Show resolved
Hide resolved
dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/GetCartIsVirtualTest.php
Show resolved
Hide resolved
lenaorobei
reviewed
Sep 5, 2019
dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/GetCartIsVirtualTest.php
Outdated
Show resolved
Hide resolved
lenaorobei
reviewed
Sep 5, 2019
dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/GetCartIsVirtualTest.php
Outdated
Show resolved
Hide resolved
lenaorobei
reviewed
Sep 5, 2019
dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/GetCartIsVirtualTest.php
Outdated
Show resolved
Hide resolved
lenaorobei
approved these changes
Sep 5, 2019
Contributor
|
Hi @lenaorobei, thank you for the review.
|
|
Hi @fooman, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description (*)
A lot of behaviour in the checkout in particular depends on if the quote is virtual or not, ie if shipping methods need to be offered or if a shipping address should be entered. This PR makes the is_virtual property of the quote available.
Fixed Issues (if relevant)
Manual testing scenarios (*)
the result should be a boolean true.
3. Add a simple product to the cart
4. Run the same graphql query again - the result should now be false.
Questions or comments
I did duplicate the _security tests here as well. I believe they could be cut if preferred as the boolean provided by this resolver by itself is not sensitive.
Contribution checklist (*)