Added createCustomerGraphQl plugin

[sedonik]

Description

Added Magento\CustomerGraphQl\Model\Plugin\Customer\CreateCustomerAccount
Added createCustomerGraphQl plugin to di.xml

Fixed Issues

1. Subscribe for newsletter even when not allowed #762: Subscribe for newsletter even when not allowed

Manual testing scenarios

1. Navigate to Stores > Settings > Configuration > Customers > Newsletter
2. In the General Options set Enabled to No
3. Save config and Flush Cache
4. Perform query:

mutation {
  createCustomer(
    input: {
      firstname: "John"
      lastname: "Lennon"
      email: "[email protected]"
      is_subscribed: true
    }
  ) {
    customer {
      email
      is_subscribed
    }
  }
}

Response

{
  "data": {
    "createCustomer": {
      "customer": {
        "email": "[email protected]",
        "is_subscribed": false
      }
    }
  }
}

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[magento-cicd2]

All committers have signed the CLA.

[sedonik]

Hi @naydav,
I've updated PR's code.
Pls, check.

[lenaorobei]

Please replace the core usage Magento\Newsletter\Observer\PredispatchNewsletterObserver with your implementation and remove unnecessary dependency.

[lenaorobei]

This is a redundant dependency.

[lenaorobei]

@sedonik, how is your progress with this ticket, are you interested to finish it?

[sedonik]

Hi @lenaorobei,

1. Deleted redundant dependency + set scopeType argument.
2. Used isActive method within Magento\Newsletter\Observer\PredispatchNewsletterObserver class by adding new PR cause it can be related not GraphQl logic.

Pls, check.
Thanks.

[lenaorobei]

Please remove redundant fixtures and use @magentoConfigFixture instead.

[lenaorobei]

Once it is fixed, please squash all commits into one. Thanks.

[sedonik]

Hi @lenaorobei,
I've set @magentoConfigFixture but after that WebAPI Tests build failed. Could you advice, please?

[lenaorobei]

@sedonik need to check ScopeInterface::SCOPE_STORE in the isActive method.

[magento-engcom-team]

Hi @lenaorobei, thank you for the review.
ENGCOM-5817 has been created to process this Pull Request

[ghost]

Hi @sedonik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.