This repository was archived by the owner on Dec 19, 2019. It is now read-only.
USPS Client Mock #753
Merged
USPS Client Mock #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mock client returning response data for domestic and iternational USPS rate requests. Un-skip USPS graphql tests. Fixes magento#739
naydav
added
Award: complex
Progress: accept
Auto-Tests: Covered
and removed
Progress: accept
labels
naydav
approved these changes
Jun 25, 2019
Contributor
|
Hi @naydav, thank you for the review. |
|
Hi @pmclain, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Mock client returning response data for domestic and iternational USPS rate
requests.
Un-skip USPS graphql tests.
Fixed Issues (if relevant)
Manual testing scenarios (*)
cd dev/tests/api-functional../../../vendor/bin/phpunit testsuite/Magento/GraphQl/Usps/SetUspsShippingMethodsOnCartTest.phpContribution checklist (*)