This repository was archived by the owner on Dec 19, 2019. It is now read-only.
magento/graphql-ce:#678 Send email to friend #752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolver throws `GraphQlAuthorizationException` when sending as guest if allow send as guest is disabled. Fixes magento#732
* Missing dep on magento/module-authorization * Separate email send logic from resolver
vpodorozh
suggested changes
Jun 22, 2019
app/code/Magento/SendFriendGraphQl/Model/Resolver/SendEmailToFriend.php
Outdated
Show resolved
Hide resolved
app/code/Magento/SendFriendGraphQl/Model/Resolver/SendEmailToFriend.php
Outdated
Show resolved
Hide resolved
|
@rleshchenko - please move |
|
@vpodorozh, I've refactored code according to your notes. Please look again |
rleshchenko
commented
Jun 22, 2019
app/code/Magento/SendFriendGraphQl/Model/Resolver/ProductService.php
Outdated
Show resolved
Hide resolved
rleshchenko
commented
Jun 22, 2019
app/code/Magento/SendFriendGraphQl/Model/Resolver/ProductService.php
Outdated
Show resolved
Hide resolved
rleshchenko
force-pushed
the
2.3-develop-678
branch
from
082f236 to
ff7c66a
Compare
rleshchenko
force-pushed
the
2.3-develop-678
branch
from
ff7c66a to
a1d87ba
Compare
rleshchenko
commented
Jun 22, 2019
app/code/Magento/SendFriendGraphQl/Model/Resolver/ProductService.php
Outdated
Show resolved
Hide resolved
vpodorozh
suggested changes
Jun 22, 2019
app/code/Magento/SendFriendGraphQl/Model/Resolver/ProductService.php
Outdated
Show resolved
Hide resolved
rleshchenko
force-pushed
the
2.3-develop-678
branch
from
973145d to
e8c102a
Compare
|
@novikor - please pick up this PR. Thx! |
…nto 2.3-develop-678
…velop-678 # Conflicts: # app/code/Magento/SendFriendGraphQl/Model/Resolver/SendEmailToFriend.php # dev/tests/api-functional/testsuite/Magento/GraphQl/SendFriend/SendFriendTest.php
lenaorobei
changed the base branch from
2.3-develop
to
1-graphql-develop-prs-fast
lenaorobei
changed the base branch from
1-graphql-develop-prs-fast
to
2.3-develop
|
@rleshchenko thank you for the contribution. Few changes I made to your PR:
|
naydav
approved these changes
Jun 24, 2019
|
Hi @rleshchenko, thank you for your contribution! |
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Previously there was using comparison with Magento\Catalog\Model\Product\Attribute\Source\Status::STATUS ENABLED instead of
comparison with Magento\Catalog\Model\Product\Visibility::VISIBILITY*. Please look at the Magento\Catalog\Model\Product::isVisibleInCatalog()
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)