Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

Links to the downloadable_product_samples are direct links #719

Merged
merged 7 commits into from
Jul 11, 2019
Merged

Links to the downloadable_product_samples are direct links #719

merged 7 commits into from
Jul 11, 2019

Conversation

@XxXgeoXxX
Copy link
Member

@XxXgeoXxX XxXgeoXxX commented May 20, 2019

Description (*)

Original issue: #710

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@XxXgeoXxX XxXgeoXxX requested a review from naydav May 20, 2019 11:04
@TomashKhamlai
Copy link
Contributor

TomashKhamlai commented May 30, 2019

@XxXgeoXxX, I have restarted tests. Is this PR ready for testing?

@XxXgeoXxX
Copy link
Member Author

XxXgeoXxX commented May 30, 2019

Hi @TomashKhamlai
Yes. Could you please check?

@XxXgeoXxX XxXgeoXxX added Progress: ready for qa Add this in any case when you need some feedback, even if automated tests are failing and removed Progress: needs update labels May 30, 2019
@TomashKhamlai TomashKhamlai added QA in progress We are checking QA passed and removed Progress: ready for qa Add this in any case when you need some feedback, even if automated tests are failing QA in progress We are checking labels May 31, 2019
@TomashKhamlai
Copy link
Contributor

TomashKhamlai commented Jun 3, 2019

Related #729. @XxXgeoXxX, can you take that task too?

@lenaorobei
Copy link
Contributor

lenaorobei commented Jun 4, 2019 •
edited
Loading

@XxXgeoXxX as per latest GraphQL syncup could you please introduce new field instead of changing the existing one? We need to take care of backward compatibility. The name can be sample_file_url.
Thank you.

@TomashKhamlai
Copy link
Contributor

TomashKhamlai commented Jun 13, 2019

@naydav, after applying this fix, issue #729 will be still reproducible.
This fix is for downloadable_product_samples, but I believe that downloadable_product_links is also an issue.

@naydav
Copy link
Contributor

naydav commented Jun 14, 2019 •
edited
Loading

@XxXgeoXxX, please check comment from @TomashKhamlai
Thanks

@lenaorobei lenaorobei changed the base branch from 2.3-develop to test-2.3 June 26, 2019 17:05
@lenaorobei lenaorobei changed the base branch from test-2.3 to 2.3-develop June 26, 2019 17:05
@magento magento deleted a comment from magento-cicd2 Jun 26, 2019
@lenaorobei
Copy link
Contributor

lenaorobei commented Jun 26, 2019

@akaplya please approve schema changes.

@lenaorobei lenaorobei requested a review from akaplya June 26, 2019 17:06
@lenaorobei
magento#710: Links to the downloadable_product_samples are direct links
86eb087 
magento#729: Links to the downloadable_product_links are direct links

- added PHP DocBlock
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jun 28, 2019

Hi @naydav, thank you for the review.
ENGCOM-5373 has been created to process this Pull Request
✳️ @naydav, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 8, 2019

Hi @naydav, thank you for the review.
ENGCOM-5373 has been created to process this Pull Request
✳️ @naydav, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@naydav naydav merged commit 86eb087 into magento:2.3-develop Jul 11, 2019
@ghost
Copy link

ghost commented Jul 11, 2019

Hi @XxXgeoXxX, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

naydav added a commit that referenced this pull request Jul 11, 2019
@naydav
ENGCOM-5373: Links to the downloadable_product_samples are direct links
506c4de 
#719
@naydav naydav mentioned this pull request Jul 11, 2019
Closed
@keharper keharper mentioned this pull request Aug 16, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akaplya akaplya Awaiting requested review from akaplya

1 more reviewer

@naydav naydav naydav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@naydav naydav

@akaplya akaplya

Labels

Auto-Tests: Not Required Component: DownloadableGraphQl Partner: ISM eCompany partners-contribution QA passed Release Line: 2.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@XxXgeoXxX @TomashKhamlai @lenaorobei @naydav @magento-engcom-team @akaplya