Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Static files fall back docs clarification 2609 #8687

Merged
merged 10 commits into from
Feb 19, 2021
Merged

Static files fall back docs clarification 2609 #8687

merged 10 commits into from
Feb 19, 2021

Conversation

@Santoshziffity
Copy link
Contributor

@Santoshziffity Santoshziffity commented Feb 12, 2021

Purpose of this pull request

This pull request (PR) for Remove the wrong path of the static file

Affected DevDocs pages

@dobooth
Copy link
Contributor

dobooth commented Feb 17, 2021

Hi @Santoshziffity. Thanks for contributing. Can you please fix this merge conflict?

@Santoshziffity
Copy link
Contributor Author

Santoshziffity commented Feb 17, 2021

Hi @Santoshziffity. Thanks for contributing. Can you please fix this merge conflict?

@ghost
Copy link

ghost commented Feb 17, 2021

Hi @Santoshziffity, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dobooth
Copy link
Contributor

dobooth commented Feb 18, 2021

@BarnyShergold Here's another OrangeCo instance. What are you using instead?

BarnyShergold
BarnyShergold suggested changes Feb 19, 2021
View reviewed changes
src/guides/v2.3/frontend-dev-guide/themes/theme-inherit.md Outdated

1. Current theme and current locale module static files: `<theme_dir>/web/i18n/<locale>/<Namespace>_<Module>`
1. Current theme module static files `<theme_dir>/<Namespace>_<Module>/web/`. Example: `app/design/frontend/SampleCompany/orange/Magento_Catalog/web/`
1. Current theme module static files `<theme_dir>/<Namespace>_<Module>/web/`.Example: `app/design/frontend/OrangeCorp/orange/Magento_Catalog/web/`
Copy link
Contributor

@BarnyShergold BarnyShergold Feb 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Current theme module static files `<theme_dir>/<Namespace>_<Module>/web/`.Example: `app/design/frontend/OrangeCorp/orange/Magento_Catalog/web/`
1. Current theme module static files `<theme_dir>/<Namespace>_<Module>/web/`.Example: `app/design/frontend/ExampleCorp/orange/Magento_Catalog/web/`

Copy link
Contributor

@BarnyShergold BarnyShergold Feb 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to clean this one file up to remove OrangeCorp

BarnyShergold
BarnyShergold approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for being so quick!

@dobooth dobooth added 2.3.x Magento 2.3 related changes 2.4.x Magento 2.4.x related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies labels Feb 19, 2021
@dobooth
Copy link
Contributor

dobooth commented Feb 19, 2021

running tests

@dobooth dobooth enabled auto-merge February 19, 2021 16:34
@dobooth dobooth merged commit d59216b into magento:master Feb 19, 2021
@ghost
Copy link

ghost commented Feb 19, 2021

Hi @Santoshziffity, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@BarnyShergold BarnyShergold BarnyShergold approved these changes

@dobooth dobooth dobooth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BarnyShergold BarnyShergold

@dobooth dobooth

Labels

2.3.x Magento 2.3 related changes 2.4.x Magento 2.4.x related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies Partner: Ziffity partners-contribution PR created by Magento partner Progress: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Santoshziffity @dobooth @BarnyShergold @magento-engcom-team