Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

@RakeshJesadiya
Copy link
Contributor

@RakeshJesadiya RakeshJesadiya commented Dec 18, 2020

Purpose of this pull request

Magento Version 2.4
This pull request (PR) improves the purchase order API and Service details. As well add grouped product requisition list details for the Magento version 2.4 only.

Affected DevDocs pages

https://devdocs.magento.com/guides/v2.4/b2b/integrations.html
https://devdocs.magento.com/guides/v2.4/b2b/bk-b2b.html

@keharper
Copy link
Contributor

@RakeshJesadiya Both of the files you edited are symlinks to 2.3 files. Since these changes are for 2.4, you'll have to break the symlinks by running the follow command on both files:

rake symlink:replace_at path=src/guides/v2.4/b2b/<filename.md>

Copy your changes to the v2.4 directory then revert the v2.3 files.

Also, are you interested in writing the documentation for the new REST endpoint?

@keharper keharper added 2.4.x Magento 2.4.x related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies labels Dec 21, 2020
@RakeshJesadiya
Copy link
Contributor Author

@keharper I am interested to write REST API endpoint.

@RakeshJesadiya
Copy link
Contributor Author

RakeshJesadiya commented Dec 21, 2020

@keharper @BarnyShergold I have error on breaking the symlinks by given command,

rakesh@rakesh-ThinkPad-E490:/var/www/html/devdocs$ rake symlink:replace_at path=/var/www/html/devdocs/src/guides/v2.4/b2b/integrations.md rake aborted! LoadError: cannot load such file -- html-proofer /var/www/html/devdocs/Rakefile:12:in <top (required)>'
/usr/share/rubygems-integration/all/gems/rake-13.0.1/exe/rake:27:in <top (required)>' (See full trace by running task with --trace)

Screenshot:
rack-slack

How Can I resolved above error?

@keharper
Copy link
Contributor

@RakeshJesadiya You need to be in the devdocs root directory when you run the command. Also, the path to the file must be relative to the root directory, so it must begin with src/guides/

@RakeshJesadiya
Copy link
Contributor Author

@keharper Please check the changes as per Version specific only.

@keharper keharper changed the base branch from master to small-changes December 23, 2020 19:11
@keharper keharper changed the base branch from small-changes to master December 23, 2020 19:12
@keharper
Copy link
Contributor

running tests

@keharper keharper merged commit 9b53c46 into magento:master Dec 23, 2020
@ghost
Copy link

ghost commented Dec 23, 2020

Hi @RakeshJesadiya, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

2.4.x Magento 2.4.x related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies Partner: EY partners-contribution PR created by Magento partner Progress: done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants