This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Update proxies.md #8402
Merged
Update proxies.md #8402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example of the proxy class from the core code.
magento-engcom-team
added
Partner: EY
partners-contribution
hguthrie
suggested changes
Dec 17, 2020
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: ready for review
labels
Contributor
Author
|
@hguthrie I have updated the changes as per your request. Thank you. |
hguthrie
approved these changes
Dec 21, 2020
Contributor
hguthrie
left a comment
hguthrie
left a comment
There was a problem hiding this comment.
As far as I can tell, it looks good. I will find someone to double-check. Thanks for the contribution.
m2-community-project
bot
added
Progress: approved
and removed
Progress: changes requested
labels
hguthrie
approved these changes
Dec 21, 2020
Contributor
hguthrie
left a comment
hguthrie
left a comment
There was a problem hiding this comment.
After asking someone internal, looks like it needs a little tweak.
@BarnyShergold Would you like to review this updated example?
Contributor
Author
|
@hguthrie I have updated the changes. Thank you. |
hguthrie
added
2.3.x
Contributor
|
running tests |
|
Hi @RakeshJesadiya, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of the declare proxy class from the core code.
Purpose of this pull request
This pull request (PR) adds the live example of how to add proxy class using di.xml file in Magento 2.
Affected DevDocs pages
https://devdocs.magento.com/guides/v2.3/extension-dev-guide/proxies.html
https://devdocs.magento.com/guides/v2.4/extension-dev-guide/proxies.html