Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

@dshevtsov
Copy link
Collaborator

@dshevtsov dshevtsov commented Jan 7, 2020

Purpose of this pull request

This pull request reverts the changes made in #6346 and applies them to 2.3.4.

Reversion scenario:

  1. Created a master_backup branch before the revert 2.3.4 GraphQL changes from master #6346 was merged
  2. Synced 2.3.4-develop with master after the revert 2.3.4 GraphQL changes from master #6346 was merged
  3. Created the ds_revert-6346 branch off the 2.3.4-develop
  4. Got the list of changed files with
git show ae574fe5608a38f2fad851d43e79cf88a03abece --name-only
  1. Reverted the files with
git checkout master_backup -- <list of changed files>

@dshevtsov dshevtsov added the 2.3.4 Magento 2.3.4 changes label Jan 7, 2020
@dshevtsov dshevtsov requested a review from keharper January 7, 2020 19:31
@dshevtsov dshevtsov self-assigned this Jan 7, 2020
@dshevtsov dshevtsov added Technical Updates to the code or processes that alter the technical content of the doc Internal Dev Differentiates work between community and Magento staff and removed Progress: review labels Jan 7, 2020
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I defer to @keharper 's approval on this

Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks complete.

@dshevtsov
Copy link
Collaborator Author

running tests

@dshevtsov dshevtsov merged commit d626955 into 2.3.4-develop Jan 7, 2020
@ghost
Copy link

ghost commented Jan 7, 2020

Hi @dshevtsov, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dshevtsov dshevtsov deleted the ds_revert-6346 branch January 7, 2020 20:37
@jeff-matthews jeff-matthews added Technical Updates to the code or processes that alter the technical content of the doc and removed Technical Updates to the code or processes that alter the technical content of the doc labels Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

2.3.4 Magento 2.3.4 changes Internal Dev Differentiates work between community and Magento staff Technical Updates to the code or processes that alter the technical content of the doc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants