Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Add getDependencies method name to example. #1760

Merged
merged 2 commits into from
Jul 17, 2018
Merged

Conversation

Vinai
Copy link
Contributor

@Vinai Vinai commented Mar 21, 2018

Add getDependencies method name to section describing patch dependencies.

Add `getDependencies` method name to section describing patch dependencies.
@jeff-matthews
Copy link
Contributor

@keharper, please review.

@@ -16,12 +16,16 @@ The declarative schema approach removes the version from the `setup_module` tabl

The sequnce of installing patches is handled through a dependency-based approach. Patches can either be independent or dependent on other patches. Independent patches can be installed in any sequence. A dependent patch requires a minimal number of patches so that it can be installed successfully.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While in here, fix sequence.

@@ -16,12 +16,16 @@ The declarative schema approach removes the version from the `setup_module` tabl

The sequnce of installing patches is handled through a dependency-based approach. Patches can either be independent or dependent on other patches. Independent patches can be installed in any sequence. A dependent patch requires a minimal number of patches so that it can be installed successfully.

To define a dependency in a patch, make a static reference to the patch class. The class can be in any module.
To define a dependency in a patch, add the method `public static function getDependencies()`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comma after inline code or perhaps turn into a list.

@keharper keharper changed the base branch from develop to master July 17, 2018 14:44
@keharper keharper merged commit cbe839a into magento:master Jul 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants