[GraphQL] Remove dynamic attributes from ProductInterface #429
Conversation
| } | ||
| ``` | ||
|
|
||
| ## System EAV attributes that should be deprecated at the storefront |
There was a problem hiding this comment.
How do you decide which attributes to move to a new container? Why not move for example new_from_date, new_to_date?
There was a problem hiding this comment.
Each eav attribute has a property is_system. If the attribute is system this is no way to remove it and very limited capabilities to manage it. that why is safe to assume that this attribute is not dynamic and can be represented as top-level fied.
| * Regular product interface overloaded with fields and almost unreadable. | ||
| * It is quite often practice to create product programmatically, so the number of attributes could be really excessive with tens thousands of attributes. | ||
| * Two Magento instances do not have the same GraphQL schema. As a result, it is near impossible to build a simple client/SDK, which could be easily transferred from one instance to another. | ||
| * It is impossible to aggregate the several Magento instances behind the common [BFF](https://docs.microsoft.com/en-us/azure/architecture/patterns/backends-for-frontends). |
There was a problem hiding this comment.
Extensions can add new attributes on the top level too. Why do we need to hide several Magento instances behind common BFF?
There was a problem hiding this comment.
for instance, if we need to add a common gateway with query cache and want to make this gateway saas solution.
| * `special_price: Float` These fields should not be used a the source of the discount since the discount also could be caused by group price or rule price, which are not reflected in this field. | ||
| The same is true for `special_from_date: String` and `special_to_date`. | ||
|
|
||
| * `options_container: String` - this field just an exposure of `catalog_product_entity` table field, information about product options could be explicitly retrieved from the corresponding field. |
There was a problem hiding this comment.
Agree, makes sense to deprecate it.
Problem
At the moment, Magento exposes Product Interface as an interface with the dynamic structure. As a result, the Product Interface in Magento has a state. This creates unnecessary complexity on the GraphQL tier. (it is challenging to cache, read schema, aggregate stores behind the same gateway so on).
Solution
Remove the state from the interface.