tests: Remove MacVim-specific flaky tests guard #1614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A while ago, flaky Vim tests would routinely fail in MacVim's repo and an intermediate hack was added to essentially pass all flaky tests and these failed tests would be added to a "pending" list for review. The issue is that this essentially gives a free pass for tests to fail and no one really has time to look at these "pending" tests when they see a green checkmark. It's much better to fail early and fast so we are forced to address them as they come up. Waiting till later tends to make these test failures harder to isolate and diagnose, leading to us just ignoring them. Even worse, flaky tests are retried multiple times, so they end up making MacVim CI run longer. Simply revert the changes that added these flaky tests and we should fix broken tests as they come up just like any other non-flaky tests.
ychin
added
Infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago, flaky Vim tests would routinely fail in MacVim's repo and an intermediate hack was added to essentially pass all flaky tests and these failed tests would be added to a "pending" list for review. The issue is that this essentially gives a free pass for tests to fail and no one really has time to look at these "pending" tests when they see a green checkmark. It's much better to fail early and fast so we are forced to address them as they come up. Waiting till later tends to make these test failures harder to isolate and diagnose, leading to us just ignoring them. Even worse, flaky tests are retried multiple times, so they end up making MacVim CI run longer.
Simply revert the changes that added these flaky tests and we should fix broken tests as they come up just like any other non-flaky tests.