Add make target to sign with ad-hoc signature with correct entitlements #1586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychin
added
the
Non User Facing
By default, building MacVim locally will sign with an ad-hoc signature with no entitlements. Release builds are then signed with the `macvim-signed` target which signs MacVim with a valid signature and embed the entitlments. This new target allows us to sign MacVim to have similar entitlements and behaviors as a release build without needing an Apple Developer signature. There are currently two possible use cases for this: 1. Package managers like Homebrew can use this to build MacVim to get the correct hardened runtime entitlements. 2. Reproducible builds (macvim-dev#1506) can use this to generate a reproducible artifact. Proper release builds are not reproducible since there's no way for a proper digital signature to be reproduced, but we can strip and re-sign with an ad-hoc signature reproducibly using this target for a decent compromise. Related: macvim-dev#1585
ychin
force-pushed
the
make-macvim-signed-adhoc
branch
from
ae95916 to
601f23a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, building MacVim locally will sign with an ad-hoc signature with no entitlements. Release builds are then signed with the
macvim-signedtarget which signs MacVim with a valid signature and embed the entitlments. This new target allows us to sign MacVim to have similar entitlements and behaviors as a release build without needing an Apple Developer signature.There are currently two possible use cases for this:
Related: #1585