Add country, boxOffice and ageRating fields for movies and series #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OMDbAPI has all 3 of these fields and MALAPI only has ageRating. While most anime is japanese there are some korean or chinese anime also on MAL so I thought it best to just set country and boxOffice as empty. boxOffice isn't applicable for series so I removed that field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OMDbAPI has all 3 of these fields and MALAPI only has
ageRating. While most anime is Japanese there are some Korean or Chinese anime also on MAL so I thought it best to just setcountry(andboxOffice) as empty. If anilistAPI (see #73) ever gets added then thecountryfield could also be populated for anime series and movies.boxOfficeisn't applicable for series so I didn't add that field.This fixes #169 and #75.