Improve unit tests and eliminate dead code/branches #69
+835
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yields 100% line and branch coverage for the def.c module.
If LWIP_DHCP is disabled, IP packets with a source address of 0.0.0.0 are dropped.
sebhub
force-pushed
the
improve-unit-tests
branch
5 times, most recently
from
4c0d45b to
2d55c7b
Compare
Reset linkoutput_ctr and linkoutput_byte_ctr in test_netif_add(). This fixes test errors if LWIP_ACD is disabled, since in this case netif_set_up() sends a gratuitous ARP.
Use right API to convert from network to host byte order. Address 0 is not a valid netmask.
Use a default case with an assertion to get rid of dead code.
If <ctype.h> is not used, then lwip_in_range() is available. Use it to optimize the hexadecimal number case. Here, the digit case is already handled. Check only for alphabet ranges and combine it with the case selection. This eliminates a couple of dead branches.
sebhub
force-pushed
the
improve-unit-tests
branch
from
2d55c7b to
7973e7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.