Skip to content

Conversation

@andrewleech
Copy link
Contributor

@andrewleech andrewleech commented Nov 13, 2025

I'm working on getting LVGL working cleanly on the NXP 1170 EVK with a LVGL v9 compatible driver in progress here: https://github.com/andrewleech/imxrt1170_display_driver

These minimal changes to the LVGL bindings files enables the build environment to enable port specific features more easily.


Summary by cubic

Add basic NXP i.MX RT (mimxrt) support by enabling port-specific LVGL GPU/PXP configuration and wiring build flags for the mimxrt port. This allows LVGL v9 to run on the RT1170 EVK with PXP acceleration.

  • New Features
    • Detect the active port in micropython.mk and add a mimxrt block that enables LV_USE_PXP, LV_USE_DRAW_PXP, LV_USE_GPU_NXP_PXP, and LV_USE_GPU_NXP_PXP_AUTO_INIT.
    • Make LV_USE_DRAW_VGLITE and LV_USE_PXP overridable in lv_conf.h so ports can turn these on without editing the config.
    • Suppress specific compiler warnings for PXP files to keep the mimxrt build clean.

Written for commit 09a4d3c. Summary will update automatically on new commits.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="lv_conf.h">

<violation number="1" location="lv_conf.h:255">
`LV_USE_PXP` is still the controlling flag for this block, but the new guard defines `LV_USE_DRAW_PXP` instead, leaving `LV_USE_PXP` undefined so the feature can never be enabled.</violation>
</file>

Since this is your first cubic review, here's how it works:

  • cubic automatically reviews your code and comments on bugs and improvements
  • Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
  • Ask questions if you need clarification on any suggestion

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

lv_conf.h Outdated
/** Use NXP's PXP on iMX RTxxx platforms. */
#define LV_USE_PXP 0
#ifndef LV_USE_DRAW_PXP
#define LV_USE_DRAW_PXP 0
Copy link

@cubic-dev-ai cubic-dev-ai bot Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LV_USE_PXP is still the controlling flag for this block, but the new guard defines LV_USE_DRAW_PXP instead, leaving LV_USE_PXP undefined so the feature can never be enabled.

Prompt for AI agents
Address the following comment on lv_conf.h at line 255:

<comment>`LV_USE_PXP` is still the controlling flag for this block, but the new guard defines `LV_USE_DRAW_PXP` instead, leaving `LV_USE_PXP` undefined so the feature can never be enabled.</comment>

<file context>
@@ -249,7 +251,9 @@
 /** Use NXP&#39;s PXP on iMX RTxxx platforms. */
-#define LV_USE_PXP 0
+#ifndef LV_USE_DRAW_PXP
+#define LV_USE_DRAW_PXP 0
+#endif
 
</file context>
Fix with Cubic

@andrewleech andrewleech force-pushed the mimx branch 2 times, most recently from 67982bc to 17c31f7 Compare November 13, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants