Skip to content

CommonJS package.json exports are backwards #161

@chrishoage

Description

@chrishoage

Describe the bug

The require exports for multiple packages are incorrect

To Reproduce

Use @headless-tree/react and @headless-tree/core in jest

Expected behavior
Types to be correct

Screenshots

  ● Test suite failed to run

    Jest encountered an unexpected token

    Jest failed to parse a file. This happens e.g. when your code or its dependencies use non-standard JavaScript syntax, or when Jest is not configured to support such syntax.

    Out of the box Jest supports Babel, which will be used to transform your files into valid JS based on your Babel configuration.

    By default "node_modules" folder is ignored by transformers.

    Here's what you can do:
     • If you are trying to use ECMAScript Modules, see https://jestjs.io/docs/ecmascript-modules for how to enable it.
     • If you are trying to use TypeScript, see https://jestjs.io/docs/getting-started#using-typescript
     • To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
     • If you need a custom transformation specify a "transform" option in your config.
     • If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.

    You'll find more details and examples of these config options in the docs:
    https://jestjs.io/docs/configuration
    For information about custom transformations, see:
    https://jestjs.io/docs/code-transformation

    Details:

    /Users/chris.hoage/projects/core/main/node_modules/.pnpm/@[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/@headless-tree/react/dist/index.d.ts:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,jest){import React, { HTMLProps } from 'react';
                                                                                      ^^^^^^

    SyntaxError: Cannot use import statement outside a module

Additional context

These are backwards

"require": {
"types": "./dist/index.js",
"default": "./dist/index.d.ts"
}

"require": {
"types": "./dist/index.js",
"default": "./dist/index.d.ts"

Manually changing these on disk to be correct (types pointing to types, default pointing to the javascript to run) fixes the Jest issue above

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions