Browser streams support & concurrency #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised spec requirements
kuhe
reviewed
Jul 21, 2025
lib/lib-storage/src/s3-transfer-manager/S3TransferManager.e2e.spec.ts
Outdated
Show resolved
Hide resolved
lib/lib-storage/src/s3-transfer-manager/S3TransferManager.e2e.spec.ts
Outdated
Show resolved
Hide resolved
lib/lib-storage/src/s3-transfer-manager/S3TransferManager.spec.ts
Outdated
Show resolved
Hide resolved
| throw failure; | ||
| } else if (isBlob(stream)) { | ||
| throw new Error("Blob not supported yet"); | ||
| const reader = stream.getReader(); |
There was a problem hiding this comment.
may need to acquire reader before reaching the stream
kuhe
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes made:
Testing
Local end to end testing, spec.ts and e2e.spec.ts files.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.